lkml.org 
[lkml]   [2019]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/8] move dropping ->ki_eventfd into iocb_destroy()
On Sun, Mar 10, 2019 at 07:08:20AM +0000, Al Viro wrote:
> From: Al Viro <viro@zeniv.linux.org.uk>
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Looks sensible, but a changelog would be nice.

> if (iocb->aio_flags & IOCB_FLAG_RESFD) {
> + struct eventfd_ctx *eventfd;
> /*
> * If the IOCB_FLAG_RESFD flag of aio_flags is set, get an
> * instance of the file* now. The file descriptor must be
> * an eventfd() fd, and will be signaled for each completed
> * event using the eventfd_signal() function.
> */
> + eventfd = eventfd_ctx_fdget((int) iocb->aio_resfd);

I don't think there is any point in the cast in either the old or new
code.

\
 
 \ /
  Last update: 2019-03-11 20:47    [W:0.133 / U:30.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site