lkml.org 
[lkml]   [2019]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT pull] x86/asm for 5.1
On Sun, 10 Mar 2019, Linus Torvalds wrote:
> On Sun, Mar 10, 2019 at 4:33 AM Thomas Gleixner <tglx@linutronix.de> wrote:
> Finally, I suspect this is all subtly buggy anyway, because your
> 'cr4_pin' thing is a global variable, but the cr4 bits are per-cpu,
> and I don't see how this works with the different CPU's setting things
> up one after each other, but the first one sets the pinned bits.
>
> So it basically "pins" the bits on CPU's before they are ready, so the
> secondary CPU's maghically get the bits set _independently_ of running
> the actual setup code to set them. That may *work*, but it sure looks
> iffy.

Which I looked at and it's a non issue. The SMAP/SMEP settings are globally
the same and the non-boot CPUs set the bits very early in the boot process.

Thanks,

tglx

\
 
 \ /
  Last update: 2019-03-11 15:22    [W:0.087 / U:36.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site