lkml.org 
[lkml]   [2019]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT pull] scheduler updates for 5.1

* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Sun, Mar 10, 2019 at 4:33 AM Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > A small set of fixes for the scheduler:
>
> What? No.
>
> This is completely broken, and even warns loudly about it.
>
> kernel/sched/cpufreq_schedutil.c: In function ‘sugov_iowait_boost’:
> ./include/linux/kernel.h:827:29: warning: comparison of distinct
> pointer types lacks a cast
> kernel/sched/cpufreq_schedutil.c:346:26: note: in expansion of macro ‘min’
> sg_cpu->iowait_boost = min(sg_cpu->iowait_boost << 1,
> SCHED_CAPACITY_SCALE);
> ^~~
>
> because 'SCHED_CAPACITY_SCALE' is of type 'long' and 'iowait_boost' is
> 'unsigned int'.
>
> Why are you sending me code that hasn't even been compiled, and call it a "fix"?

Sorry about that - we'll sort this out!

Thanks,

Ingo

\
 
 \ /
  Last update: 2019-03-11 10:09    [W:0.077 / U:2.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site