lkml.org 
[lkml]   [2019]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: lan9303: fix missing error handling
From
From: Kangjie Lu <kjlu@umn.edu>
Date: Sun, 10 Mar 2019 03:08:56 -0500

> Both lan9303_phy_write and regmap_write may fail. The fix adds
> the error handling to print error messages upon failure.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>

It's ignored elsewhere in this driver in places you haven't handled.

I doubt this is much of an improvement to the driver to be quite
honest.

I disagree with the mantra that just because an error is potentially
returned, that it always must be checked.

\
 
 \ /
  Last update: 2019-03-10 19:01    [W:0.040 / U:2.100 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site