lkml.org 
[lkml]   [2019]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] isdn: hfcpci: fix potential NULL pointer dereference
From
From: Kangjie Lu <kjlu@umn.edu>
Date: Fri, 8 Mar 2019 23:46:04 -0600

> In case ioremap fails, the fix reports an error and returns.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>

First, you shouldn't print the information log message if this fails.

Second you are leaking hc->hw.fifos, you have to clean up any resources
allocated up until this point if you fail.

\
 
 \ /
  Last update: 2019-03-10 18:57    [W:0.051 / U:18.572 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site