[lkml]   [2019]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[tip:perf/core] perf hist: Remove the needless callchain.h include from hist.h
Commit-ID:  71551288d2fde0c24df3c248e3e80be92783376d
Author: Arnaldo Carvalho de Melo <>
AuthorDate: Tue, 29 Jan 2019 12:04:58 +0100
Committer: Arnaldo Carvalho de Melo <>
CommitDate: Wed, 6 Feb 2019 10:00:38 -0300

perf hist: Remove the needless callchain.h include from hist.h

Nothing that is provided by callchain.h is used there, just things that
should've be directly included in hist.h, such as rbtree.h and a
map_symbol forward declaration.

Remove it so that we reduce the headers dependency tree.

Cc: Adrian Hunter <>
Cc: Jiri Olsa <>
Cc: Namhyung Kim <>
Signed-off-by: Arnaldo Carvalho de Melo <>
tools/perf/util/hist.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
index 38a72eb81427..6b872079ead5 100644
--- a/tools/perf/util/hist.h
+++ b/tools/perf/util/hist.h
@@ -2,9 +2,9 @@
#ifndef __PERF_HIST_H
#define __PERF_HIST_H

+#include <linux/rbtree.h>
#include <linux/types.h>
#include <pthread.h>
-#include "callchain.h"
#include "evsel.h"
#include "header.h"
#include "color.h"
@@ -13,6 +13,7 @@
struct hist_entry;
struct hist_entry_ops;
struct addr_location;
+struct map_symbol;
struct mem_info;
struct branch_info;
struct symbol;
 \ /
  Last update: 2019-02-09 13:37    [W:0.038 / U:3.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site