[lkml]   [2019]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 1/2] tpm: Uni fy the send callback behaviourä
On Fri, Feb 08, 2019 at 09:00:57PM +0200, Jarkko Sakkinen wrote:
> It all looks now legit, but just in case I'll add a check for the return
> value to tpm_try_transmit() and a warning if it is not zero in the
> success case (and after that zeroing of rc).

Now the commits are applied both master and next, and these are
the checks for send():

rc = chip->ops->send(chip, buf, count);
if (rc < 0) {
if (rc != -EPIPE)
"%s: send(): error %d\n", __func__, rc);
return rc;

/* A sanity check. send() should just return zero on success e.g.
* not the command length.
if (rc > 0) {
"%s: send(): invalid value %d\n", __func__, rc);
rc = 0;

Should be fairly safe play now.


 \ /
  Last update: 2019-02-08 20:18    [W:0.092 / U:2.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site