lkml.org 
[lkml]   [2019]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCHv7 5/6] coresight: etm4x: Add ETM PIDs for SDM845 and MSM8996
On Thu, 31 Jan 2019 at 17:54, Sai Prakash Ranjan
<saiprakash.ranjan@codeaurora.org> wrote:
>
> Instead of overriding the peripheral id(PID) check in AMBA
> by hardcoding them in DT, add the PIDs to the ETM4x driver.
> Here we use Unique Component Identifier(UCI) for MSM8996
> since the ETM and CPU debug module shares the same PIDs.
> SDM845 does not support CPU debug module.
>
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> ---
> For testing, all dependent patches are in below tree:
> * https://github.com/saiprakash-ranjan/linux/tree/coresight-next
>
> This patch depends on UCI support by Mike Leach in below link:
> * https://lore.kernel.org/lkml/20190130234051.2294-1-mike.leach@linaro.org/
> ---
> drivers/hwtracing/coresight/coresight-etm4x.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
> index 08ce37c9475d..5819ced2beec 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
> @@ -1078,11 +1078,15 @@ static struct amba_cs_uci_id uci_id_etm4[] = {
> };
>
> static const struct amba_id etm4_ids[] = {
> - CS_AMBA_ID(0x000bb95d), /* Cortex-A53 */
> - CS_AMBA_ID(0x000bb95e), /* Cortex-A57 */
> - CS_AMBA_ID(0x000bb95a), /* Cortex-A72 */
> - CS_AMBA_ID(0x000bb959), /* Cortex-A73 */
> - CS_AMBA_UCI_ID(0x000bb9da, uci_id_etm4), /* Cortex-A35 */
> + CS_AMBA_ID(0x000bb95d), /* Cortex-A53 */
> + CS_AMBA_ID(0x000bb95e), /* Cortex-A57 */
> + CS_AMBA_ID(0x000bb95a), /* Cortex-A72 */
> + CS_AMBA_ID(0x000bb959), /* Cortex-A73 */
> + CS_AMBA_UCI_ID(0x000bb9da, uci_id_etm4),/* Cortex-A35 */
> + CS_AMBA_UCI_ID(0x000f0205, uci_id_etm4),/* Qualcomm Kryo */
> + CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */
> + CS_AMBA_ID(0x000bb802), /* Qualcomm Kryo 385 Cortex-A55 */
> + CS_AMBA_ID(0x000bb803), /* Qualcomm Kryo 385 Cortex-A75 */

I am good with this patch but there isn't much I can do with it until
Mike's patchset has been merged. Please submit again when that has
been done.

Thanks,
Mathieu

> {},
> };
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>

\
 
 \ /
  Last update: 2019-02-07 21:26    [W:0.183 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site