lkml.org 
[lkml]   [2019]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 2/2] net: Change TCA_ACT_* to TCA_ID_* to match that of TCA_ID_POLICE
From
From: Eli Cohen <eli@mellanox.com>
Date: Thu, 7 Feb 2019 09:45:49 +0200

> diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c
> index 902957beceb3..d54cb608dbaf 100644
> --- a/net/sched/act_simple.c
> +++ b/net/sched/act_simple.c
> @@ -19,8 +19,6 @@
> #include <net/netlink.h>
> #include <net/pkt_sched.h>
>
> -#define TCA_ACT_SIMP 22
> -
> #include <linux/tc_act/tc_defact.h>
> #include <net/tc_act/tc_defact.h>
>

I would do this in patch #1.

Actually, because you didn't, after patch #1 there are two #defines
evaluated for this macro. One in pkt_cls.h and one here.

The only reason the compiler doesn't warn and complain is because the
definitions are identical.

Thank you.

\
 
 \ /
  Last update: 2019-02-07 19:02    [W:0.084 / U:1.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site