lkml.org 
[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build warning after merge of the net-next tree
Hi Dave,

On Sun, 03 Feb 2019 20:26:06 -0800 (PST) David Miller <davem@davemloft.net> wrote:
>
> Thanks, I just pushed the following:
>
> ====================
> [PATCH] net: Fix fall through warning in y2038 tstamp changes.
>
> net/core/sock.c: In function 'sock_setsockopt':
> net/core/sock.c:914:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> sock_set_flag(sk, SOCK_TSTAMP_NEW);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> net/core/sock.c:915:2: note: here
> case SO_TIMESTAMPING_OLD:
> ^~~~
>
> Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> net/core/sock.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/core/sock.c b/net/core/sock.c
> index a8904ae40713..71ded4d8025c 100644
> --- a/net/core/sock.c
> +++ b/net/core/sock.c
> @@ -912,6 +912,7 @@ int sock_setsockopt(struct socket *sock, int level, int optname,
>
> case SO_TIMESTAMPING_NEW:
> sock_set_flag(sk, SOCK_TSTAMP_NEW);
> + /* fall through */
> case SO_TIMESTAMPING_OLD:
> if (val & ~SOF_TIMESTAMPING_MASK) {
> ret = -EINVAL;

Looks good, thanks.

--
Cheers,
Stephen Rothwell
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-02-04 05:33    [W:0.033 / U:3.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site