lkml.org 
[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 064/305] USB: serial: cypress_m8: fix interrupt-out transfer length
    3.16.63-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 56445eef55cb5904096fed7a73cf87b755dfffc7 upstream.

    Fix interrupt-out transfer length which was being set to the
    transfer-buffer length rather than the size of the outgoing packet.

    Note that no slab data was leaked as the whole transfer buffer is always
    cleared before each transfer.

    Fixes: 9aa8dae7b1fa ("cypress_m8: use usb_fill_int_urb where appropriate")
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/serial/cypress_m8.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/serial/cypress_m8.c
    +++ b/drivers/usb/serial/cypress_m8.c
    @@ -773,7 +773,7 @@ send:

    usb_fill_int_urb(port->interrupt_out_urb, port->serial->dev,
    usb_sndintpipe(port->serial->dev, port->interrupt_out_endpointAddress),
    - port->interrupt_out_buffer, port->interrupt_out_size,
    + port->interrupt_out_buffer, actual_size,
    cypress_write_int_callback, port, priv->write_urb_interval);
    result = usb_submit_urb(port->interrupt_out_urb, GFP_ATOMIC);
    if (result) {
    \
     
     \ /
      Last update: 2019-02-03 15:31    [W:3.680 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site