[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 3.16 248/305] dmaengine: at_hdmac: fix module unloading
3.16.63-rc1 review patch.  If anyone has any objections, please let me know.


From: Richard Genoud <>

commit 77e75fda94d2ebb86aa9d35fb1860f6395bf95de upstream.

of_dma_controller_free() was not called on module onloading.
This lead to a soft lockup:
watchdog: BUG: soft lockup - CPU#0 stuck for 23s!
Modules linked in: at_hdmac [last unloaded: at_hdmac]
when of_dma_request_slave_channel() tried to call ofdma->of_dma_xlate().

Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding")
Acked-by: Ludovic Desroches <>
Signed-off-by: Richard Genoud <>
Signed-off-by: Vinod Koul <>
Signed-off-by: Ben Hutchings <>
drivers/dma/at_hdmac.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -1564,6 +1564,8 @@ static int at_dma_remove(struct platform
struct resource *io;

+ if (pdev->dev.of_node)
+ of_dma_controller_free(pdev->dev.of_node);

 \ /
  Last update: 2019-02-03 15:30    [W:1.212 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site