[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 3.16 111/305] net: bcmgenet: fix OF child-node lookup
3.16.63-rc1 review patch.  If anyone has any objections, please let me know.


From: Johan Hovold <>

commit d397dbe606120a1ea1b11b0020c3f7a3852da5ac upstream.

Use the new of_get_compatible_child() helper to lookup the mdio child
node instead of using of_find_compatible_node(), which searches the
entire tree from a given start node and thus can return an unrelated
(i.e. non-child) node.

This also addresses a potential use-after-free (e.g. after probe
deferral) as the tree-wide helper drops a reference to its first
argument (i.e. the node of the device being probed).

Fixes: aa09677cba42 ("net: bcmgenet: add MDIO routines")
Cc: David S. Miller <>
Reviewed-by: Florian Fainelli <>
Signed-off-by: Johan Hovold <>
Signed-off-by: Rob Herring <>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <>
drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
@@ -410,7 +410,7 @@ static int bcmgenet_mii_of_init(struct b
if (!compat)
return -ENOMEM;

- mdio_dn = of_find_compatible_node(dn, NULL, compat);
+ mdio_dn = of_get_compatible_child(dn, compat);
if (!mdio_dn) {
dev_err(kdev, "unable to find MDIO bus node\n");
 \ /
  Last update: 2019-02-03 14:53    [W:0.794 / U:12.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site