lkml.org 
[lkml]   [2019]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 2/3] arm64: dts: imx8mq: Add the buck vdd_arm regulator
Date
On 19-02-28 22:15:46, Shawn Guo wrote:
> On Fri, Feb 15, 2019 at 06:07:23PM +0000, Abel Vesa wrote:
> > According to the schematics, this is a MP2147 switch converter
> > which is controlled by GPIO1_IO13. When set the gpio is set to
> > high the regulator output is set to 0.9V. When the gpio is set
> > to low the regulator output is set to 1V.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 36 ++++++++++++++++++++++++++++
> > 1 file changed, 36 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > index 54737bf..e5da3dd 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > @@ -31,6 +31,35 @@
> > gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> > enable-active-high;
> > };
> > +
> > + buck2_reg: buck2 {
>
> Please follow regulator-xxx naming convention.
>

Will do.

> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_buck2>;
> > + compatible = "regulator-gpio";
> > + regulator-name = "vdd_arm";
> > + regulator-min-microvolt = <900000>;
> > + regulator-max-microvolt = <1000000>;
> > + gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
> > + states = <1000000 0x0
> > + 900000 0x1>;
> > + enable-active-high;
>
> The property only makes sense when enable-gpio is present?
>

Will remove it.

> Shawn
>
> > + };
> > +};
> > +
> > +&A53_0 {
> > + cpu-supply = <&buck2_reg>;
> > +};
> > +
> > +&A53_1 {
> > + cpu-supply = <&buck2_reg>;
> > +};
> > +
> > +&A53_2 {
> > + cpu-supply = <&buck2_reg>;
> > +};
> > +
> > +&A53_3 {
> > + cpu-supply = <&buck2_reg>;
> > };
> >
> > &fec1 {
> > @@ -203,6 +232,13 @@
> > };
> >
> > &iomuxc {
> > + pinctrl_buck2: vddarmgrp {
> > + fsl,pins = <
> > + MX8MQ_IOMUXC_GPIO1_IO13_GPIO1_IO13 0x19
> > + >;
> > +
> > + };
> > +
> > pinctrl_fec1: fec1grp {
> > fsl,pins = <
> > MX8MQ_IOMUXC_ENET_MDC_ENET1_MDC 0x3
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-kernel&amp;data=02%7C01%7Cabel.vesa%40nxp.com%7C7f571130a0114fb84fe408d69d87606f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636869602101094479&amp;sdata=vsNlfbgqglUuVsFyULjTMm5Hqwd6chpsVa0V05ugDG0%3D&amp;reserved=0
\
 
 \ /
  Last update: 2019-02-28 15:29    [W:0.051 / U:1.364 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site