lkml.org 
[lkml]   [2019]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] Add support SUNIX Multi-I/O board
On Wed, Feb 27, 2019 at 03:17:02PM +0800, Morris Ku wrote:
> Add Kconfig and Makefile entry.
>
> ---
> Kconfig | 2 ++
> Makefile | 1 +
> 2 files changed, 3 insertions(+)

<snip>

Oh, this series has lots of issues, not the least being this single
patch breaks the build :(

Every patch needs to build properly, or at the least, not stop
everything else from building.

I recommend reading Documentation/SubmittingPatches for how to do a
patch submission properly, and if you have specific questions after
reading that, I will be glad to answer them.

Also, please use scripts/checkpatch.pl on your patches, it will point
out lots of issues that I'll be nice and not mention at the moment :)

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-02-27 09:18    [W:0.016 / U:8.096 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site