lkml.org 
[lkml]   [2019]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86/stacktrace: export save_stack_trace_tsk_reliable
From
Date
On 2/27/19 5:25 PM, Joe Lawrence wrote:
> On 2/27/19 4:31 PM, Thomas Gleixner wrote:
>> On Wed, 27 Feb 2019, Joe Lawrence wrote:
>>
>>> The ppc64le implementation of save_stack_trace_tsk_reliable() is
>>> exported, so do the same with x86.
>>
>> And what's the in tree module user of this? I can't find one and just
>> because PPC has an export with no user is not a convincing argument to add
>> another one. The proper solution is to remove the unused PPC export.
>>
>
> Good point.
>
> For that matter, I do see in-tree modules making use of
> save_stack_trace, but who is calling save_stack_trace_tsk (exported by
> most arches) and save_stack_trace_regs (exported by openrisc, powerpc,
> s390)?

Well, at least for save_stack_trace_tsk there is the out-of-tree kpatch
core module[1]. (Kpatch drops that call if the kernel provides
livepatch functionality.)

[1] https://github.com/dynup/kpatch/blob/master/kmod/core/core.c#L275

-- Joe

\
 
 \ /
  Last update: 2019-02-28 00:21    [W:0.033 / U:6.012 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site