lkml.org 
[lkml]   [2019]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 27/34] mm: pagewalk: Add 'depth' parameter to pte_hole
From
Date
On 2/27/19 9:06 AM, Steven Price wrote:
> #ifdef CONFIG_SHMEM
> static int smaps_pte_hole(unsigned long addr, unsigned long end,
> - struct mm_walk *walk)
> + __always_unused int depth, struct mm_walk *walk)
> {

I think this 'depth' argument is a mistake. It's synthetic and it's
surely going to be a source of bugs.

The page table dumpers seem to be using this to dump out the "name" of a
hole which seems a bit bogus in the first place. I'd much rather teach
the dumpers about the length of the hole, "the hole is 0x12340000 bytes
long", rather than "there's a hole at this level".

\
 
 \ /
  Last update: 2019-02-27 18:39    [W:0.184 / U:5.220 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site