lkml.org 
[lkml]   [2019]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v16] i2c: Add drivers for the AMD PCIe MP2 I2C controller
Hi Elie,

I love your patch! Yet something to improve:

[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v5.0-rc8 next-20190227]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Elie-Morisse/i2c-Add-drivers-for-the-AMD-PCIe-MP2-I2C-controller/20190227-225657
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: i386-allmodconfig (attached as .config)
compiler: gcc-8 (Debian 8.2.0-21) 8.2.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

drivers/i2c/busses/i2c-amd-mp2-pci.c: In function 'amd_mp2_rw':
>> drivers/i2c/busses/i2c-amd-mp2-pci.c:105:3: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]
writeq((u64)i2c_common->dma_addr,
^~~~~~
writel
cc1: some warnings being treated as errors

vim +105 drivers/i2c/busses/i2c-amd-mp2-pci.c

88
89 int amd_mp2_rw(struct amd_i2c_common *i2c_common, enum i2c_cmd reqcmd)
90 {
91 struct amd_mp2_dev *privdata = i2c_common->mp2_dev;
92 union i2c_cmd_base i2c_cmd_base;
93
94 amd_mp2_cmd_rw_fill(i2c_common, &i2c_cmd_base, reqcmd);
95 amd_mp2_c2p_mutex_lock(i2c_common);
96
97 if (i2c_common->msg->len <= 32) {
98 i2c_cmd_base.s.mem_type = use_c2pmsg;
99 if (reqcmd == i2c_write)
100 memcpy_toio(privdata->mmio + AMD_C2P_MSG2,
101 i2c_common->msg->buf,
102 i2c_common->msg->len);
103 } else {
104 i2c_cmd_base.s.mem_type = use_dram;
> 105 writeq((u64)i2c_common->dma_addr,
106 privdata->mmio + AMD_C2P_MSG2);
107 }
108
109 return amd_mp2_cmd(i2c_common, i2c_cmd_base);
110 }
111 EXPORT_SYMBOL_GPL(amd_mp2_rw);
112

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2019-02-27 17:02    [W:0.067 / U:5.296 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site