lkml.org 
[lkml]   [2019]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] perf diff: Support --time filter option
On Tue, Feb 26, 2019 at 08:11:07PM +0800, Jin Yao wrote:

SNIP

> + abstime_tmp = abstime_ostr;
>
> data__for_each_file(i, d) {
> - d->session = perf_session__new(&d->data, false, &tool);
> + d->session = perf_session__new(&d->data, false, &pdiff.tool);
> if (!d->session) {
> pr_err("Failed to open %s\n", d->data.path);
> ret = -1;
> goto out_delete;
> }
>
> + if (abstime_ostr) {
> + ret = parse_absolute_time(d, &abstime_tmp);
> + if (ret < 0)
> + goto out_delete;
> + } else if (pdiff.time_str) {
> + ret = parse_percent_time(d);
> + if (ret < 0)
> + goto out_delete;
> + } else {
> + pdiff.range_num = 1;

hum, why are we setting range_num to 1 again?

it's really hard to parse this code, maybe
it'd be better in separate loop/function
that would setup just timestamps..


thanks,
jirka

\
 
 \ /
  Last update: 2019-02-27 10:28    [W:0.064 / U:1.620 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site