lkml.org 
[lkml]   [2019]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V8 1/4] dt-bindings: fsl: scu: add thermal binding
Date
[...]
> > On Thu, Feb 21, 2019 at 06:38:30AM +0000, Anson Huang wrote:
> > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system
> > > controller, the system controller is in charge of system power,
> > > clock and thermal sensors etc. management, Linux kernel has to
> > > communicate with system controller via MU (message unit) IPC to get
> > > temperature from thermal sensors, this patch adds binding doc for
> > > i.MX system controller thermal driver.
> > >
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > Reviewed-by: Rob Herring <robh@kernel.org>

You need drop the former Reviewed-by once there's significant changes.

> > > +Thermal bindings based on SCU Message Protocol
> > > +------------------------------------------------------------
> > > +
> > > +Required properties:
> > > +- compatible: Should be :
> > > + "fsl,imx8qxp-sc-thermal"
> > > + followed by "fsl,imx-sc-thermal";
> > > +
> > > +- #thermal-sensor-cells: See
> > Documentation/devicetree/bindings/thermal/thermal.txt
> > > + for a description.
> > > +
> > > +- imx,sensor-resource-id: Property array to specify each thermal
> zone's
> > sensor resource ID.
> >
> > If this is an array...
> >
> > > +
> > > Example (imx8qxp):
> > > -------------
> > > lsio_mu1: mailbox@5d1c0000 {
> > > @@ -168,6 +181,12 @@ firmware {
> > > rtc: rtc {
> > > compatible = "fsl,imx8qxp-sc-rtc";
> > > };
> > > +
> > > + tsens: thermal-sensor {
> > > + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc-
> > thermal";
> > > + #thermal-sensor-cells = <0>;
> > > + imx,sensor-resource-id = <IMX_SC_R_SYSTEM>;
> >
> > then this example should have an array, to be better express how this
> > is supposed to work. Can you please resend this with an array instead?
>
> On i.MX8QXP, there is ONLY 1 thermal zone available currently, but the thermal
> driver is supposed to support multi thermal zones as well for i.MX8QM, in V9
> patch set I just sent, I use the " imx,sensor-resource-id " element count to
> determine how many thermal sensors will be supported, so that we can also
> get rid of searching the thermal-zones' child node, I improved the description
> as below, is it OK?
>

Device tree is used to describe HW.
#thermal-sensor-cells is less to be an optional parameter to me.
If HW supports, then it should be 1 and update the example accordingly.

Regards
Dong Aisheng

> 41 +- imx,sensor-resource-id: A single integer for single thermal zone's
> resource ID or
> 42 + an array of integers to specify each
> thermal zone's sensor
> 43 + resource ID.

\
 
 \ /
  Last update: 2019-02-26 13:02    [W:0.064 / U:3.264 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site