lkml.org 
[lkml]   [2019]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 15/15] perf script python: add Python3 support to sql scripts
From
Date
On 2/25/19 6:54 AM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Feb 25, 2019 at 11:51:19AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Fri, Feb 22, 2019 at 03:06:19PM -0800, Tony Jones escreveu:
>>> Support both Python2 and Python3 in the exported-sql-viewer.py,
>>> export-to-postgresql.py and export-to-sqlite.py scripts
> <SNIP>
>>> @@ -234,12 +236,17 @@ perf_db_export_mode = True
>>> perf_db_export_calls = False
>>> perf_db_export_callchains = False
>>>
>>> +def printerr(*args, **kw_args):
>>> + print(*args, file=sys.stderr, **kw_args)
>>> +
>>> +def printdate(*args, **kw_args):
>>> + print(datetime.datetime.today(), *args, sep=' ', **kw_args)
>>
>> So this one introduces inconsistencies in indentation, i.e. the above
>> two routines don't use tabs and one uses 4 spaces while the other uses 8
>> spaces :-\
>>
>> I'm converting them to use tabs, like the rest of this script, ok?
>
> But it is not applying, Adrian did work recently here, can you please
> address this and resubmit?

I was using perf/perf/core. I'll take a look.

Also, I agree we should be consistent on indentation.

\
 
 \ /
  Last update: 2019-02-25 18:20    [W:0.053 / U:37.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site