lkml.org 
[lkml]   [2019]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] habanalabs: driver's Kconfig must select DMA_SHARED_BUFFER
On Sat, Feb 23, 2019 at 11:19:07AM +0200, Oded Gabbay wrote:
> On Sat, Feb 23, 2019 at 11:17 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Feb 22, 2019 at 09:29:59PM +0200, Oded Gabbay wrote:
> > > The driver uses the DMA_BUF module which is built only if
> > > DMA_SHARED_BUFFER is selected. DMA_SHARED_BUFFER doesn't have any
> > > dependencies so it is ok to select it (as done by many other components).
> > >
> > > Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
> >
> > kbuild reported this, right? You should always add that type of credit
> > to the patch. I'll go add it by hand this time...
> >
> > thanks,
> >
> > greg k-h
>
> Ah, I didn't know that, sorry. It wasn't enforced in drm :(

Really? The drm developers should know better, that's not ok :(

\
 
 \ /
  Last update: 2019-02-23 20:31    [W:0.033 / U:64.688 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site