lkml.org 
[lkml]   [2019]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH-tip v2 04/10] locking/rwsem: Micro-optimize rwsem_try_read_lock_unqueued()
On Fri, Feb 15, 2019 at 03:50:04PM -0500, Waiman Long wrote:
> The atomic_long_cmpxchg_acquire() in rwsem_try_read_lock_unqueued() is
> replaced by atomic_long_try_cmpxchg_acquire() to simpify the code and
> generate slightly better assembly code. There is no functional change.

Might be nice to illustrate the improvement in the commit message, but
it seems that try_cmpxchg is generally preferred for x86, so:

Acked-by: Will Deacon <will.deacon@arm.com>

Will

\
 
 \ /
  Last update: 2019-02-21 15:16    [W:0.050 / U:14.512 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site