lkml.org 
[lkml]   [2019]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first
Date

> > If there is a generic PHY node under USB controller, and there is a
> > USB PHY at other sides, both ci->phy and ci->usb_phy are valid, I
> > original thought it is the problem you met.
>
> Right, this is not the problem we are having. The problem is that legacy USB PHYs
> are not grabbed from device-tree. Instead, they are currently matched with their
> type in the list of registered USB PHYs, making it impossible to use 2 distinct USB
> PHYs this way.
>
> > Since you are trying to fix the legacy USB PHY grab issue, I hope you
> > could consider the generic PHY as well.
>
> What do you have in mind about generic PHYs? Everything already works as
> expected with them.
>

Current code w/o your patch, it is possible both ci->phy and ci->usb_phy are valid
if the USB PHY is not at the device tree, but generic PHY is at the device tree.
If you don't want to fix this issue with this patch, it is ok too. We could fix it later.

Peter

\
 
 \ /
  Last update: 2019-02-21 09:39    [W:0.066 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site