lkml.org 
[lkml]   [2019]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] ASoC: samsung: i2s: Fix the secondary platform device registration
From
Date
On 2/18/19 09:31, Krzysztof Kozlowski wrote:
> On Fri, 15 Feb 2019 at 15:48, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:

>> diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
>> index 6bf0f55d1e51..e36c44e2f1bb 100644
>> --- a/sound/soc/samsung/i2s.c
>> +++ b/sound/soc/samsung/i2s.c
>> @@ -1359,11 +1359,10 @@ static int i2s_create_secondary_device(struct samsung_i2s_priv *priv)
>>
>> static void i2s_delete_secondary_device(struct samsung_i2s_priv *priv)
>> {
>> - if (priv->pdev_sec) {
>> - platform_device_del(priv->pdev_sec);
>> - priv->pdev_sec = NULL;
>> - }
>> + platform_device_unregister(priv->pdev_sec);
>> + priv->pdev_sec = NULL;
>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Although I think that you might need to re-order calls in
> samsung_i2s_remove(). In general they should be in exact reverse order
> of probe(). In this case, clk_disable_unprepare(priv->clk) should be
> after unregistering secondary device. If order has to be different
> because of some reasons - could you document them in comment?

Makes sense, I will change the order and resend both patches.

Thanks,
Sylwester

\
 
 \ /
  Last update: 2019-02-18 12:43    [W:0.081 / U:5.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site