lkml.org 
[lkml]   [2019]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01/11] powerpc: remove dead ifdefs in <asm/checksum.h>
From
Date


Le 14/02/2019 à 18:05, Christoph Hellwig a écrit :
> On Thu, Feb 14, 2019 at 09:26:19AM +0100, Christophe Leroy wrote:
>> Could you also remove the 'config GENERIC_CSUM' item in
>> arch/powerpc/Kconfig ?
>
> All the separate declarations go away later in this series.
>

I saw, but the purpose of the later patch is to replace arch defined
GENERIC_CSUM by a common one that arches select. For the powerpc you are
not in that case as the powerpc does not select GENERIC_CSUM.

So I really believe that all stale bits of remaining GENERIC_CSUM in
powerpc should go away as a single dedicated patch, as a fix of commit
d4fde568a34a ("powerpc/64: Use optimized checksum routines on
little-endian")

Regarding the #ifdef __KERNEL__ , I think we should do a wide cleanup in
arch/powerpc/include/asm, not only asm/checksum.h

Christophe

\
 
 \ /
  Last update: 2019-02-15 09:18    [W:0.056 / U:29.764 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site