lkml.org 
[lkml]   [2019]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: APUv2/v3 board support V3
On Fri, Feb 15, 2019 at 12:05 AM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> Hi folks,
>
>

Thanks for an update.

Linus, this one looks good enough, though some style minors can be addressed:
- redundant parens (and actually I prefer to see x = readl(); x |=
...; writel(); in three lines)
- useless blank lines
- style of parameters where one per line (it's not needed in this drivers)

In any case, FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> this is version 3 of my APUv2/APUv3 series.
>
> change in V3:
>
> * gpio driver
> * drop unncessary gpio id checks
> * cleanup amd_fch_gpio_set()
> * move iores outside probe()
> * shorter NULL checks and correct error in probe()
> * apu board driver
> * drop unneeded init.h
> * drop unnecessary comments
> * clean up logging
> * dont need to depend on KEYBOARD_GPIO
>
>
> --mtx



--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-02-15 19:16    [W:0.108 / U:4.860 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site