[lkml]   [2019]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 13/13] x86: mm: Convert dump_pagetables to use walk_page_range
On 2/15/19 9:02 AM, Steven Price wrote:
> arch/x86/mm/dump_pagetables.c | 281 ++++++++++++++++++----------------
> 1 file changed, 146 insertions(+), 135 deletions(-)

I'll look through this in more detail in a bit. But, I'm a bit bummed
out by the diffstat. When I see patches add a bunch of infrastructure,
I *really* hope for code simplification.

Looking at the diff, I think it gets there. The code you add is
simpler than the code you remove. But, the diffstat is misleading.

I'd probably address this disparity for each patch in the changelogs.

 \ /
  Last update: 2019-02-15 18:17    [W:0.158 / U:1.544 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site