lkml.org 
[lkml]   [2019]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] PCI: hv: Replace hv_vp_set with hv_vpset
On Mon, Jan 28, 2019 at 09:49:32PM -0800, Maya Nakamura wrote:
> On Sun, Jan 27, 2019 at 05:11:48AM +0000, Michael Kelley wrote:
> > From: Maya Nakamura <m.maya.nakamura@gmail.com> Sent: Saturday, January 26, 2019 12:52 AM
> > >
> > > Remove a duplicate definition of VP set (hv_vp_set) and use the common
> > > definition (hv_vpset) that is used in other places.
> > >
> > > Change the order of the members in struct hv_pcibus_device so that the
> > > declaration of retarget_msi_interrupt_params is the last member. Struct
> > > hv_vpset, which contains a flexible array, is nested two levels deep in
> > > struct hv_pcibus_device via retarget_msi_interrupt_params.
> > >
> > > Add a comment that retarget_msi_interrupt_params should be the last member
> > > of struct hv_pcibus_device.
> > >
> > > Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> > > ---
> > > Change in v2:
> > > - None
> > >
> >
> > Right -- there was no code change. But it's customary to note that
> > you updated the commit message.
> >
> Thank you for your feedback. I will edit the change log in v3.
>
> > Reviewed-by: Michael Kelley <mikelley@microsoft.com>

I will add Michael's tag to v3 (unless Michael is not happy with that),
it is missing there.

Lorenzo

\
 
 \ /
  Last update: 2019-02-15 11:27    [W:0.068 / U:12.200 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site