lkml.org 
[lkml]   [2019]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH][V3] regulator: axp20x: remove a redundant null check on rdev
Date
From: Colin Ian King <colin.king@canonical.com>

Currently rdev is dereferenced when assigning desc before rdev is null
checked, this is leading to static analysis warnings. However, rdev
can never be null, so the null check is redundant and can be removed.

Detected by CoverityScan, CID#1476031 ("Dereference before null check")

Fixes: 77e3e3b165db ("regulator: axp20x: add software based soft_start for AXP209 LDO3")
Signed-off-by: Colin Ian King <colin.king@canonical.com>

--

V2: Fix 2nd occurrance of this thinko
V3: Remove null check, Dan Carpenter noted that rdev can never be null.
---
drivers/regulator/axp20x-regulator.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index 6d081c8321a1..db1750df579d 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -372,9 +372,6 @@ static int axp20x_set_ramp_delay(struct regulator_dev *rdev, int ramp)
const int *slew_rates;
int rate_count = 0;

- if (!rdev)
- return -EINVAL;
-
desc = rdev->desc;

switch (axp20x->variant) {
--
2.20.1
\
 
 \ /
  Last update: 2019-02-15 10:46    [W:0.056 / U:1.628 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site