lkml.org 
[lkml]   [2019]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/2] PCI: Fix runtime PME generation from D3hot
On Thu, Feb 14, 2019 at 03:26:19PM -0600, Bjorn Helgaas wrote:
> On Thu, Jan 31, 2019 at 08:07:44PM +0300, Mika Westerberg wrote:
> > Hi all,
> >
> > Heiner reported [1] that runtime PME generation of his network card does
> > not work after commit 0e157e528604 ("PCI/PME: Implement runtime PM
> > callbacks") that landed in v4.20. Reverting the commit helps but it has
> > another drawback, which I originally tried to solve with the commit, that
> > the PCIe hierarchy wakes up immediately after being put into D3cold.
> >
> > This series of two patches tries to fix both issues so that PME wakes up
> > from D3hot and that the hierarchy does not wake up immediately from D3cold.
> >
> > The previous version of the series can be found here:
> >
> > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1892241.html
> >
> > Changes from the previous version:
> >
> > * Add tags from Heiner and Rafael
> > * Update changelog to mention relevent PCIe spec sections
> > * Add comment to pcie_disable_interrupt() explaining why and what is
> > masked
> >
> > [1] https://www.spinics.net/lists/linux-pci/msg79051.html
> >
> > Mika Westerberg (2):
> > Revert "PCI/PME: Implement runtime PM callbacks"
> > PCI: pciehp: Disable Data Link Layer State Changed event on suspend
>
> I tentatively applied these to pci/pm for v5.1.

Thanks!

> I suspect these should be marked for stable (v4.20+)?

Yes, I think it makes sense.

> I don't think the bugzilla in the second patch is directly relevant to
> that patch. I'd like to update the patch with a more relevant
> bugzilla if you have or can open one?

I created a new one and included the link in my reply to the other
patch.

\
 
 \ /
  Last update: 2019-02-15 10:38    [W:0.073 / U:17.956 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site