lkml.org 
[lkml]   [2019]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC v3 17/19] of: unittest: migrate tests to run on KUnit
On Wed, Nov 28, 2018 at 12:56 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Nov 28, 2018 at 1:38 PM Brendan Higgins
> <brendanhiggins@google.com> wrote:
> >
> > Migrate tests without any cleanup, or modifying test logic in anyway to
> > run under KUnit using the KUnit expectation and assertion API.
>
> Nice! You beat me to it. This is probably going to conflict with what
> is in the DT tree for 4.21. Also, please Cc the DT list for
> drivers/of/ changes.
>
> Looks good to me, but a few mostly formatting comments below.

I just realized that we never talked about your other comments, and I
still have some questions. (Sorry, it was the last thing I looked at
while getting v4 ready.) No worries if you don't get to it before I
send v4 out, I just didn't want you to think I was ignoring you.

>
> >
> > Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> > ---
> > drivers/of/Kconfig | 1 +
> > drivers/of/unittest.c | 1405 ++++++++++++++++++++++-------------------
> > 2 files changed, 752 insertions(+), 654 deletions(-)
> >
<snip>
> > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> > index 41b49716ac75f..a5ef44730ffdb 100644
> > --- a/drivers/of/unittest.c
> > +++ b/drivers/of/unittest.c
<snip>
> > -
> > -static void __init of_unittest_find_node_by_name(void)
> > +static void of_unittest_find_node_by_name(struct kunit *test)
>
> Why do we have to drop __init everywhere? The tests run later?

From the standpoint of a unit test __init doesn't really make any
sense, right? I know that right now we are running as part of a
kernel, but the goal should be that a unit test is not part of a
kernel and we just include what we need.

Even so, that's the future. For now, I did not put the KUnit
infrastructure in the .init section because I didn't think it belonged
there. In practice, KUnit only knows how to run during the init phase
of the kernel, but I don't think it should be restricted there. You
should be able to run tests whenever you want because you should be
able to test anything right? I figured any restriction on that is
misleading and will potentially get in the way at worst, and
unnecessary at best especially since people shouldn't build a
production kernel with all kinds of unit tests inside.

>
> > {
> > struct device_node *np;
> > const char *options, *name;
> >
<snip>
> >
> >
> > - np = of_find_node_by_path("/testcase-data/missing-path");
> > - unittest(!np, "non-existent path returned node %pOF\n", np);
> > + KUNIT_EXPECT_EQ_MSG(test,
> > + of_find_node_by_path("/testcase-data/missing-path"),
> > + NULL,
> > + "non-existent path returned node %pOF\n", np);
>
> 1 tab indent would help with less vertical code (in general, not this
> one so much).

Will do.

>
> > of_node_put(np);
> >
> > - np = of_find_node_by_path("missing-alias");
> > - unittest(!np, "non-existent alias returned node %pOF\n", np);
> > + KUNIT_EXPECT_EQ_MSG(test, of_find_node_by_path("missing-alias"), NULL,
> > + "non-existent alias returned node %pOF\n", np);
> > of_node_put(np);
> >
> > - np = of_find_node_by_path("testcase-alias/missing-path");
> > - unittest(!np, "non-existent alias with relative path returned node %pOF\n", np);
> > + KUNIT_EXPECT_EQ_MSG(test,
> > + of_find_node_by_path("testcase-alias/missing-path"),
> > + NULL,
> > + "non-existent alias with relative path returned node %pOF\n",
> > + np);
> > of_node_put(np);
> >
<snip>
> >
> > -static void __init of_unittest_property_string(void)
> > +static void of_unittest_property_string(struct kunit *test)
> > {
> > const char *strings[4];
> > struct device_node *np;
> > int rc;
> >
> > np = of_find_node_by_path("/testcase-data/phandle-tests/consumer-a");
> > - if (!np) {
> > - pr_err("No testcase data in device tree\n");
> > - return;
> > - }
> > -
> > - rc = of_property_match_string(np, "phandle-list-names", "first");
> > - unittest(rc == 0, "first expected:0 got:%i\n", rc);
> > - rc = of_property_match_string(np, "phandle-list-names", "second");
> > - unittest(rc == 1, "second expected:1 got:%i\n", rc);
> > - rc = of_property_match_string(np, "phandle-list-names", "third");
> > - unittest(rc == 2, "third expected:2 got:%i\n", rc);
> > - rc = of_property_match_string(np, "phandle-list-names", "fourth");
> > - unittest(rc == -ENODATA, "unmatched string; rc=%i\n", rc);
> > - rc = of_property_match_string(np, "missing-property", "blah");
> > - unittest(rc == -EINVAL, "missing property; rc=%i\n", rc);
> > - rc = of_property_match_string(np, "empty-property", "blah");
> > - unittest(rc == -ENODATA, "empty property; rc=%i\n", rc);
> > - rc = of_property_match_string(np, "unterminated-string", "blah");
> > - unittest(rc == -EILSEQ, "unterminated string; rc=%i\n", rc);
> > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, np);
> > +
> > + KUNIT_EXPECT_EQ(test,
> > + of_property_match_string(np,
> > + "phandle-list-names",
> > + "first"),
> > + 0);
> > + KUNIT_EXPECT_EQ(test,
> > + of_property_match_string(np,
> > + "phandle-list-names",
> > + "second"),
> > + 1);
>
> Fewer lines on these would be better even if we go over 80 chars.

On the of_property_match_string(...), I have no opinion. I will do
whatever you like best.

Nevertheless, as far as the KUNIT_EXPECT_*(...), I do have an opinion: I am
trying to establish a good, readable convention. Given an expect statement
structured as
```
KUNIT_EXPECT_*(
test,
expect_arg_0, ..., expect_arg_n,
fmt_str, fmt_arg_0, ..., fmt_arg_n)
```
where `test` is the `struct kunit` context argument, `expect_arg_{0, ..., n}`
are the arguments the expectations is being made about (so in the above example,
`of_property_match_string(...)` and `1`), and `fmt_*` is the optional format
string that comes at the end of some expectations.

The pattern I had been trying to promote is the following:

1) If everything fits on 1 line, do that.
2) If you must make a line split, prefer to keep `test` on its own line,
`expect_arg_{0, ..., n}` should be kept together, if possible, and the format
string should follow the conventions already most commonly used with format
strings.
3) If you must split up `expect_arg_{0, ..., n}` each argument should get its
own line and should not share a line with either `test` or any `fmt_*`.

The reason I care about this so much is because expectations should be
extremely easy to read; they are the most important part of a unit
test because they tell you what the test is verifying. I am not
married to the formatting I proposed above, but I want something that
will be extremely easy to identify the arguments that the expectation
is on. Maybe that means that I need to add some syntactic fluff to
make it clearer, I don't know, but this is definitely something we
need to get right, especially in the earliest examples.

>
> > + KUNIT_EXPECT_EQ(test,
> > + of_property_match_string(np,
> > + "phandle-list-names",
> > + "third"),
> > + 2);
> > + KUNIT_EXPECT_EQ_MSG(test,
> > + of_property_match_string(np,
> > + "phandle-list-names",
> > + "fourth"),
> > + -ENODATA,
> > + "unmatched string");
> > + KUNIT_EXPECT_EQ_MSG(test,
> > + of_property_match_string(np,
> > + "missing-property",
> > + "blah"),
> > + -EINVAL,
> > + "missing property");
> > + KUNIT_EXPECT_EQ_MSG(test,
> > + of_property_match_string(np,
> > + "empty-property",
> > + "blah"),
> > + -ENODATA,
> > + "empty property");
> > + KUNIT_EXPECT_EQ_MSG(test,
> > + of_property_match_string(np,
> > + "unterminated-string",
> > + "blah"),
> > + -EILSEQ,
> > + "unterminated string");
<snip>
> > /* test insertion of a bus with parent devices */
> > -static void __init of_unittest_overlay_10(void)
> > +static void of_unittest_overlay_10(struct kunit *test)
> > {
> > - int ret;
> > char *child_path;
> >
> > /* device should disable */
> > - ret = of_unittest_apply_overlay_check(10, 10, 0, 1, PDEV_OVERLAY);
> > - if (unittest(ret == 0,
> > - "overlay test %d failed; overlay application\n", 10))
> > - return;
> > + KUNIT_ASSERT_EQ_MSG(test,
> > + of_unittest_apply_overlay_check(test,
> > + 10,
> > + 10,
> > + 0,
> > + 1,
> > + PDEV_OVERLAY),
>
> I prefer putting multiple args on a line and having fewer lines.

Looking at this now, I tend to agree, but I don't think I saw a
consistent way to break them up for these functions. I figured there
should be some type of pattern.

>
> > + 0,
> > + "overlay test %d failed; overlay application\n",
> > + 10);
> >
> > child_path = kasprintf(GFP_KERNEL, "%s/test-unittest101",
> > unittest_path(10, PDEV_OVERLAY));
> > - if (unittest(child_path, "overlay test %d failed; kasprintf\n", 10))
> > - return;
> > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, child_path);
> >
> > - ret = of_path_device_type_exists(child_path, PDEV_OVERLAY);
> > + KUNIT_EXPECT_TRUE_MSG(test,
> > + of_path_device_type_exists(child_path,
> > + PDEV_OVERLAY),
> > + "overlay test %d failed; no child device\n", 10);
> > kfree(child_path);
> > -
> > - unittest(ret, "overlay test %d failed; no child device\n", 10);
> > }
<snip>

\
 
 \ /
  Last update: 2019-02-13 02:45    [W:0.206 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site