Messages in this thread Patch in this message |  | | Date | Mon, 11 Feb 2019 22:02:30 +0100 | From | Peter Seiderer <> | Subject | Re: [RFC v1] tlv320aic32x4: delay i2c access by 1 ms after hardware reset |
| |
Hello Mark,
On Mon, 11 Feb 2019 15:04:25 +0000, Mark Brown <broonie@kernel.org> wrote:
> On Sun, Feb 10, 2019 at 04:45:19PM +0100, Peter Seiderer wrote: > > > @@ -972,6 +972,8 @@ static int aic32x4_component_probe(struct snd_soc_component *component) > > gpio_set_value(aic32x4->rstn_gpio, 1); > > } > > > > + mdelay(1); > > + > > Perhaps only do this if we toggled the GPIO? If the device wasn't in > reset then there's no need to wait.
You are absolutely right with this, will re-spin the patch with the suggested change, thanks for review...
Regards, Peter
|  |