lkml.org 
[lkml]   [2019]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/5] ARM: convert to unified syntax
On Sun, 10 Feb 2019, Stefan Agner wrote:

> This patchset converts all assembly code to unified assembler
> language (UAL) compatible assembly code. From what I can tell,
> this mainly boils down to using conditional infixes instead of
> postfixes.
>
> Most of the conversion has been done using the following regular
> expression:
> find ./arch/arm/ -name "*.[hSc]" -exec sed -i -r \
> "s/^((\s*[._a-zA-Z0-9]*[\:\(])?\s*)([a-z]{3})(eq|ne|cs|hs|cc|lo|mi|pl|vs|vc|hi|ls|ge|lt|gt|le|al)([a-z]{1,2})(\s)/\1\3\5\4\6/"
> \
> {} \;
>
> The expression resulted in some false positives and missed some
> instances where infix conditionals have been used. With this
> changes applied, I compiled several kernel configurations
> successfully and without a warning.
>
> The file arch/arm/probes/kprobes/test-arm.c is still using some
> divided syntax assembler.
>
> This does not allow to use LLVM's integrated assembler just yet,
> there is still some assembler which the integrated assembler does
> not like (yet). But it is a big step towards that direction.

OK....

Please document why you added .syntax unified in the commit log of each
patch where this is added along with a link to the gcc PR. Then you may
add Acked-by: Nicolas Pitre <nico@linaro.org> to the whole series.


Nicolas

\
 
 \ /
  Last update: 2019-02-10 22:25    [W:0.212 / U:1.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site