lkml.org 
[lkml]   [2019]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available
On Thu, Jan 31, 2019 at 06:17:31PM +0800, lantianyu1986@gmail.com wrote:
>
>

This comment needs to be indented one tab or it looks like we're outside
the funciton.

> +/*
> + * Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic,
> + * set x2apic destination mode to physcial mode when x2apic is available
> + * and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs
> + * have 8-bit APIC id.
> + */
> +# if IS_ENABLED(CONFIG_HYPERV_IOMMU)
> + if (x2apic_supported())
> + x2apic_phys = 1;
> +# endif

The IS_ENABLED() macro is really magical. You could write this like so:

if (IS_ENABLED(CONFIG_HYPERV_IOMMU) && x2apic_supported())
x2apic_phys = 1;

It works the same and is slightly more pleasant to look at.

regards,
dan carpenter

\
 
 \ /
  Last update: 2019-02-01 08:08    [W:0.137 / U:15.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site