lkml.org 
[lkml]   [2019]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] driver core: Fix test_async_driver_probe if NUMA is disabled
From
Date
On Mon, 2019-12-09 at 12:44 -0800, Guenter Roeck wrote:
> On Wed, Dec 04, 2019 at 09:18:28AM -0800, Alexander Duyck wrote:
> > > I thought the code is specifically checking devices which it previously
> > > created, which are well defined and understood test devices. After all,
> > > the check is in the test driver's probe function. Guess I really don't
> > > understand the code. Please take my patch as bug report, and submit
> > > whatever fix you think is correct.
> >
> > Sorry I had overlooked that this is the test code.
> >
> > I suppose it should be fine since we specify the node ID for all instances
> > where we register an asychronous test device.
> >
>
> That isn't exacly an endorsement. Would you mind submitting a patch
> that is acceptable for you ? I'll be more than happy to test it.
>
> Thanks,
> Guenter

It isn't really worth the trouble.

I would have been concerned if the patch was in something other than test
code, and I hasn't paid close attention to the specific file being edited.

Your patch is more than enough to address the original issue you reported.

Thanks.

Acked-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>

\
 
 \ /
  Last update: 2019-12-09 22:00    [W:0.040 / U:10.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site