lkml.org 
[lkml]   [2019]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/5] media: hantro: Reduce H264 extra space for motion vectors
From
Date
On Wed, 2019-11-20 at 21:44 +0900, Tomasz Figa wrote:
> Hi Jonas,
>
> On Thu, Nov 7, 2019 at 7:34 AM Jonas Karlman <jonas@kwiboo.se> wrote:
> > A decoded 8-bit 4:2:0 frame need memory for up to 448 bytes per
> > macroblock with additional 32 bytes on multi-core variants.
> >
> > Memory layout is as follow:
> >
> > +---------------------------+
> > > Y-plane 256 bytes x MBs |
> > +---------------------------+
> > > UV-plane 128 bytes x MBs |
> > +---------------------------+
> > > MV buffer 64 bytes x MBs |
> > +---------------------------+
> > > MC sync 32 bytes |
> > +---------------------------+
> >
> > Reduce the extra space allocated now that motion vector buffer offset no
> > longer is based on the extra space.
> >
> > Only allocate extra space for 64 bytes x MBs of motion vector buffer
> > and 32 bytes for multi-core sync.
> >
> > Fixes: a9471e25629b ("media: hantro: Add core bits to support H264 decoding")
> > Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> > ---
> > Changes in v3:
> > - add memory layout to code comment (Boris)
> > Changes in v2:
> > - updated commit message
> > ---
> > drivers/staging/media/hantro/hantro_v4l2.c | 20 ++++++++++++++++++--
> > 1 file changed, 18 insertions(+), 2 deletions(-)
> >
>
> Thanks for the patch!
>
> What platform did you test it on and how? Was it tested with IOMMU enabled?

Hello Tomasz,

Please note that this series has been picked-up and is merged
in v5.5-rc1.

IIRC, we tested these patches on RK3399 and RK3288 (that means
with an IOMMU). I've just ran some more extensive tests on RK3288,
on media/master; and I plan to test some more on RK3399 later this week.

Do you have any specific concern in mind?

Thanks,
Ezequiel

\
 
 \ /
  Last update: 2019-12-09 19:12    [W:0.058 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site