lkml.org 
[lkml]   [2019]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1] ARM i.MX6q: make sure PHY fixup for KSZ9031 is applied only on one board
Hi Oleksij

> This patch changes the MICREL KSZ9031 fixup, which was introduced for
> the "Data Modul eDM-QMX6" board in following patch, to be only activated
> for this specific board.

...

> static void __init imx6q_enet_phy_init(void)
> {
> + /* Warning: please do not extend this fixup list. This fixups are
> + * applied even on boards where related PHY is not directly connected
> + * to the ethernet controller. For example with switch in the middle.
> + */
> if (IS_BUILTIN(CONFIG_PHYLIB)) {
> phy_register_fixup_for_uid(PHY_ID_KSZ9021, MICREL_PHY_ID_MASK,
> ksz9021rn_phy_fixup);
> - phy_register_fixup_for_uid(PHY_ID_KSZ9031, MICREL_PHY_ID_MASK,
> - ksz9031rn_phy_fixup);
> +
> + if (of_machine_is_compatible("dmo,imx6q-edmqmx6"))
> + phy_register_fixup_for_uid(PHY_ID_KSZ9031,
> + MICREL_PHY_ID_MASK,
> + ksz9031rn_phy_fixup);
> +
> phy_register_fixup_for_uid(PHY_ID_AR8031, 0xffffffef,
> ar8031_phy_fixup);
> phy_register_fixup_for_uid(PHY_ID_AR8035, 0xffffffef,

What about the other 3 fixups? Are they not also equally broken,
applied for all boards, not specific boards?

Andrew

\
 
 \ /
  Last update: 2019-12-09 18:16    [W:0.045 / U:3.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site