lkml.org 
[lkml]   [2019]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64: dts: allwinner: Convert to new-style SPDX license identifiers
On Mon, Dec 02, 2019 at 08:45:44PM +0100, Clément Péron wrote:
> > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > > > > index f335f7482a73..84b7e9936300 100644
> > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > > > > @@ -1,4 +1,4 @@
> > > > > -// SPDX-License-Identifier: (GPL-2.0+ or MIT)
> > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > > > > /*
> > > > > * Copyright (C) 2019 Clément Péron <peron.clem@gmail.com>
> > > > > */
> > > >
> > > > And I'm not sure what this one (and the next) is?
> > >
> > > The license expressions in dual licensed files is wrong here, "OR"
> > > should be uppercase.
> > > I can move it to a separate commit if you like.
> >
>
> > Ah, right, indeed, this should be in a separate patch.
> So how many patch do you recommend here ?
>
> 1 for the or -> OR style fix.
> 1 to change to SPDX.
> and 1 to use the same // style everywhere ?

Yep :)

Maxime

\
 
 \ /
  Last update: 2019-12-09 17:53    [W:0.047 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site