lkml.org 
[lkml]   [2019]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/4] usb: host: xhci-tegra: Switch to use %ptT
On Wed, Oct 02, 2019 at 01:39:23PM +0200, Thierry Reding wrote:
> On Tue, Oct 01, 2019 at 04:47:17PM +0300, Andy Shevchenko wrote:
> > Use %ptT instead of open coded variant to print content of
> > time64_t type in human readable format.

> > timestamp = le32_to_cpu(header->fwimg_created_time);
> > - time64_to_tm(timestamp, 0, &time);
> >
> > - dev_info(dev, "Firmware timestamp: %ld-%02d-%02d %02d:%02d:%02d UTC\n",
> > - time.tm_year + 1900, time.tm_mon + 1, time.tm_mday,
> > - time.tm_hour, time.tm_min, time.tm_sec);
> > + dev_info(dev, "Firmware timestamp: %ptT UTC\n", &timestamp);
>
> Can you please switch this to "Firmware timestamp: %ptTd %ptTt UTC\n" so
> that the string stays the same? As discussed earlier there may be issues
> if this string is changed. It may be unwise for someone to rely on the
> exact format of this kernel log string, but why risk potentially causing
> annoying changes in behaviour if we can easily avoid it?

I don't think it's worth to do, though if you are insisting...

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2019-12-09 17:41    [W:0.039 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site