lkml.org 
[lkml]   [2019]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: cs35l32: add missed regulator_bulk_disable in remove
On Fri, Dec 06, 2019 at 03:51:46PM +0800, Chuhong Yuan wrote:

> @@ -501,6 +501,8 @@ static int cs35l32_i2c_remove(struct i2c_client *i2c_client)
> /* Hold down reset */
> gpiod_set_value_cansleep(cs35l32->reset_gpio, 0);
>
> + regulator_bulk_disable(ARRAY_SIZE(cs35l32->supplies),
> + cs35l32->supplies);

This is a similar situation to the one Charles pointed out - the driver
is using runtime PM to manage the regulators so unless the device is
active when removed the regulators won't be enabled.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-12-09 17:22    [W:0.028 / U:43.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site