lkml.org 
[lkml]   [2019]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net/x25: add new state X25_STATE_5
On 2019-12-07 20:59, David Miller wrote:
> From: Martin Schiller <ms@dev.tdt.de>
> Date: Fri, 6 Dec 2019 14:34:18 +0100
>
>> + switch (frametype) {
>> +
>> + case X25_CLEAR_REQUEST:
>
> Please remove this unnecessary empty line.
>
>> + if (!pskb_may_pull(skb, X25_STD_MIN_LEN + 2))
>> + goto out_clear;
>
> A goto path for a single call site? Just inline the operations here.

Well, I was guided by the code style of the other states.
I could add a patch to also clean up the other states.
What do you think?

\
 
 \ /
  Last update: 2019-12-09 06:29    [W:0.039 / U:6.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site