lkml.org 
[lkml]   [2019]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/12] PCMCIA: use dev_err/dev_info instead of printk
On Sun, Dec 08, 2019 at 05:09:36PM +0100, Simon Geis wrote:
> Fix the checkpatch warning:
> WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ...
> then pr_err(... to printk(KERN_ERR ...
> and
> WARNING: printk() should include KERN_<LEVEL> facility level
> by using dev_err()/dev_info() according to the message.

Thanks for the patch! The actual diff looks fine, but the commit message
still needs some refinement. Please do not repeat the checkpatch warnings
(removing them from existing files is not a goal in itself!), but
describe the goal of the patch ("Improve the log output by using the
device-aware dev_err()/dev_info() functions. While at it, update one
remaining printk(KERN_ERR ...) call to the preferred pr_err() call.")

> Split the assignment of variable 'sock' in in order to get access to
> struct_info with the 'container_of' function call.

As that merely describes what the code does, it is not needed in the
commit message.

> pr_err is used where no struct pci_dev is available.

If you describe the goal of the patch above, that becomes clear by itself.
So you may want to remove this line as well.

Thanks,
Dominik

\
 
 \ /
  Last update: 2019-12-08 22:18    [W:0.051 / U:15.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site