lkml.org 
[lkml]   [2019]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] fs: Fix a missing check bug
Date
The return value of link_free_space(ctl, info) is checked out-sync. Only one branch of an if statement checks this return value after WARN_ON(ret).

Since this path pair is similar in semantic, there might be a missing check bug.

Fix this by simply adding a check on ret.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
fs/btrfs/free-space-cache.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
index 3283da419200..acbb3a59d344 100644
--- a/fs/btrfs/free-space-cache.c
+++ b/fs/btrfs/free-space-cache.c
@@ -2437,6 +2437,8 @@ int btrfs_remove_free_space(struct btrfs_block_group *block_group,
if (info->bytes) {
ret = link_free_space(ctl, info);
WARN_ON(ret);
+ if (ret)
+ goto out_lock;
} else {
kmem_cache_free(btrfs_free_space_cachep, info);
}
--
2.21.0 (Apple Git-122)
\
 
 \ /
  Last update: 2019-12-07 16:03    [W:0.046 / U:3.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site