lkml.org 
[lkml]   [2019]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: media: go7007: fix a miss of snd_card_free
From
Date
> I think using goto is really much better than freeing after every error.

Thanks for your positive feedback.


> I will send a new version if others also agree with this pattern.

* The error handling pattern would be supported by the Linux coding style.
The agreement on corresponding changes can occasionally become more challenging.

* I would interpret Dan Carpenter's review comment (from 2017-09-19) in the way
that he should be mentioned by the tag “Reported-by” in a subsequent patch.
https://lkml.org/lkml/2017/9/19/115

Regards,
Markus

\
 
 \ /
  Last update: 2019-12-06 18:01    [W:0.034 / U:5.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site