lkml.org 
[lkml]   [2019]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git pull] vfs.git d_inode/d_flags barriers
On Thu, Dec 05, 2019 at 06:15:54PM -0800, Linus Torvalds wrote:
> On Thu, Dec 5, 2019 at 5:38 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes
>
> I'm not pulling this.
>
> Commit 6c2d4798a8d1 ("new helper: lookup_positive_unlocked()") results
> in a new - and valid - compiler warning:
>
> fs/quota/dquot.c: In function ‘dquot_quota_on_mount’:
> fs/quota/dquot.c:2499:1: warning: label ‘out’ defined but not used
> [-Wunused-label]
> 2499 | out:
> | ^~~
>
> and I don't want to see new warnings in my tree.
>
> I wish linux-next would complain about warnings (assuming this had
> been there), because they aren't ok.

Fixed... Could you pull #fixes1 instead? diff is literally removal of one
line; updated shortlog/diffstat follows:

The following changes since commit 3e5aeec0e267d4422a4e740ce723549a3098a4d1:

cramfs: fix usage on non-MTD device (2019-11-23 21:44:49 -0500)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes1

for you to fetch changes up to 7fcd59b64a7b69718cc851865a1578138b481541:

fs/namei.c: fix missing barriers when checking positivity (2019-12-05 21:04:35 -0500)

----------------------------------------------------------------
Al Viro (4):
fs/namei.c: pull positivity check into follow_managed()
new helper: lookup_positive_unlocked()
fix dget_parent() fastpath race
fs/namei.c: fix missing barriers when checking positivity

fs/cifs/cifsfs.c | 7 +------
fs/dcache.c | 6 ++++--
fs/debugfs/inode.c | 6 +-----
fs/kernfs/mount.c | 2 +-
fs/namei.c | 56 ++++++++++++++++++++++++++++----------------------
fs/nfsd/nfs3xdr.c | 4 +---
fs/nfsd/nfs4xdr.c | 11 +---------
fs/overlayfs/namei.c | 24 ++++++++--------------
fs/quota/dquot.c | 8 +-------
include/linux/dcache.h | 5 +++++
include/linux/namei.h | 1 +
11 files changed, 56 insertions(+), 74 deletions(-)

\
 
 \ /
  Last update: 2019-12-06 03:29    [W:0.045 / U:7.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site