lkml.org 
[lkml]   [2019]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v10 04/11] x86/entry/64: Adapt assembly for PIE support
On Wed, Dec 04, 2019 at 04:09:41PM -0800, Thomas Garnier wrote:

> @@ -1625,7 +1627,11 @@ first_nmi:
> addq $8, (%rsp) /* Fix up RSP */
> pushfq /* RFLAGS */
> pushq $__KERNEL_CS /* CS */
> - pushq $1f /* RIP */
> + pushq $0 /* Future return address */

We're building an IRET frame, the IRET frame does not have a 'future
return address' field.

> + pushq %rdx /* Save RAX */

fail..

> + leaq 1f(%rip), %rdx /* RIP */

nonsensical comment

> + movq %rdx, 8(%rsp) /* Put 1f on return address */
> + popq %rdx /* Restore RAX */

fail..

> iretq /* continues at repeat_nmi below */
> UNWIND_HINT_IRET_REGS
> 1:
> --
> 2.24.0.393.g34dc348eaf-goog
>

\
 
 \ /
  Last update: 2019-12-05 10:04    [W:0.129 / U:7.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site