lkml.org 
[lkml]   [2019]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 2/2] usb: overridable hub bInterval by device node
On Tue, Dec 3, 2019 at 11:23 PM Alan Stern <stern@rowland.harvard.edu> wrote:
>
> On Tue, 3 Dec 2019, Ikjoon Jang wrote:
>
> > This patch enables hub device to override its own endpoint descriptor's
> > bInterval when the hub has a device node with "hub,interval" property.
> >
> > When we know reducing autosuspend delay for built-in HIDs is better for
> > power saving, we can reduce it to the optimal value. But if a parent hub
> > has a long bInterval, mouse lags a lot from more frequent autosuspend.
> > So this enables overriding bInterval for a hard wired hub device only
> > when we know that reduces the power consumption.
> >
> > Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> > Acked-by: Alan Stern <stern@rowland.harvard.edu>
> > ---
> > drivers/usb/core/config.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
> > index 5f40117e68e7..95ec5af42a1c 100644
> > --- a/drivers/usb/core/config.c
> > +++ b/drivers/usb/core/config.c
> > @@ -6,6 +6,7 @@
> > #include <linux/usb.h>
> > #include <linux/usb/ch9.h>
> > #include <linux/usb/hcd.h>
> > +#include <linux/usb/of.h>
> > #include <linux/usb/quirks.h>
> > #include <linux/module.h>
> > #include <linux/slab.h>
> > @@ -257,6 +258,14 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno, int inum,
> > memcpy(&endpoint->desc, d, n);
> > INIT_LIST_HEAD(&endpoint->urb_list);
> >
> > + /* device node property overrides bInterval */
> > + if (usb_of_has_combined_node(to_usb_device(ddev))) {
> > + u32 interval = 0;
>
> Coding style: there should be a blank line here. Also, you don't need
> the "= 0" initializer.
>
> Otherwise okay.

Okay, I will fix that.
Thank you!

>
> Alan Stern
>
> > + if (!of_property_read_u32(ddev->of_node, "hub,interval",
> > + &interval))
> > + d->bInterval = min_t(u8, interval, 255);
> > + }
> > +
> > /*
> > * Fix up bInterval values outside the legal range.
> > * Use 10 or 8 ms if no proper value can be guessed.
>

\
 
 \ /
  Last update: 2019-12-04 08:09    [W:0.071 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site