lkml.org 
[lkml]   [2019]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 08/11] gpiolib: emit a debug message when adding events to a full kfifo
On Wed, Dec 4, 2019 at 6:04 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Currently if the line-event kfifo is full, we just silently drop any new
> events. Add a ratelimited debug message so that we at least have some
> trace in the kernel log of event overflow.
>

Hmm... I don't like prints in IRQ context (even threaded).
Can we rather switch to trace points at some point?

> @@ -975,6 +975,9 @@ static irqreturn_t lineevent_irq_thread(int irq, void *p)
> ret = kfifo_in_spinlocked(&le->events, &ge, 1, &le->wait.lock);
> if (ret)
> wake_up_poll(&le->wait, EPOLLIN);
> + else
> + pr_debug_ratelimited(
> + "%s: event FIFO is full - event dropped\n", __func__);
>
> return IRQ_HANDLED;

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-12-04 23:29    [W:0.107 / U:43.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site