lkml.org 
[lkml]   [2019]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] stmmac: debugfs entry name is not be changed when udev rename device name.
From
Date
Hello!

On 31.12.2019 5:03, Jiping Ma wrote:

> Add one notifier for udev changes net device name.
>
> Signed-off-by: Jiping Ma <jiping.ma2@windriver.com>
> ---
> .../net/ethernet/stmicro/stmmac/stmmac_main.c | 38 ++++++++++++++++++-
> 1 file changed, 37 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index b14f46a57154..c1c877bb4421 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -4038,6 +4038,40 @@ static int stmmac_dma_cap_show(struct seq_file *seq, void *v)
> }
> DEFINE_SHOW_ATTRIBUTE(stmmac_dma_cap);
>
> +/**
> + * Use network device events to create/remove/rename
> + * debugfs file entries
> + */
> +static int stmmac_device_event(struct notifier_block *unused,
> + unsigned long event, void *ptr)
> +{
> + struct net_device *dev = netdev_notifier_info_to_dev(ptr);
> + struct stmmac_priv *priv = netdev_priv(dev);
> +
> + switch (event) {
> + case NETDEV_CHANGENAME:
> + if (priv->dbgfs_dir)
> + priv->dbgfs_dir = debugfs_rename(stmmac_fs_dir,
> + priv->dbgfs_dir,
> + stmmac_fs_dir,
> + dev->name);
> + break;
> +
> + case NETDEV_GOING_DOWN:
> + break;
> +
> + case NETDEV_UP:
> + break;

Why not merge the above 2 cases? Or just remove them('event' is not *enum*)?

> + }
> +
> +done:
> + return NOTIFY_DONE;
> +}
[...]

MBR, Sergei

\
 
 \ /
  Last update: 2019-12-31 11:13    [W:0.041 / U:2.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site